Update to new version of behaviors #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c74ad0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Uh oh! @pksjce, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
size-limit report 📦
|
siddharthkp
reviewed
Nov 21, 2023
siddharthkp
approved these changes
Nov 21, 2023
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Merged
|
Tagging @jonrohan @JelloBagel as they have authored 1.3.5/1.3.6 and 1.40/1.50 respectively |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility-audits/issues/4515
Changelog
The calculations to position the action menu next to it's trigger anchor point had a bug where if the available vertical viewport space was lesser than the height of the action menu it would cut off a portion of the top menu above the viewport.
We fixed this by adding tweaks to the calculations and verifying through new and old test cases in the @primer/behaviors repository. In this PR I'm updating to newer version of @primer/behaviors with my fixes.
Before screenshot
After screenshot
Rollout strategy
This will be a patch release since it's a bug fix.
Testing & Reviewing
This can be tested in this storybook. Keep the devtools window open so as to reduce viewport height to be less than action menu height. https://primer.style/react/storybook/?path=/story/components-actionmenu-examples--multiple-sections
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.