-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip2: Update direction mapping #4098
Conversation
🦋 Changeset detectedLatest commit: c66bc61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be nice to follow this up to a change in the Playground
story that lets us pick a direction from a predefined list of options instead of accepting any string.
Oh great feedback! I didn't even realise that it was set as string, sorry my bad. I updated it 🤗 |
Just realised that the Tooltip v2
se
,sw
,ne
,nw
directions are not correct.What we have vs What is expected.
Changelog
New
Changed
Updated the
align
property values in the mapping objects based on the info from the behaviours:Removed
Rollout strategy
Testing & Reviewing
All Directions story is a good one to test
Merge checklist