-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Link inline
prop description
#4127
Conversation
🦋 Changeset detectedLatest commit: 9b53a27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Just wanted to leave a couple notes for the deprecation process that I believe we're hoping to follow:
What would be a good place for us to include/document this info so that it's more apparent when making deprecation changes? Would that versioning guide be a good place? Just want to make sure we've captured all of these things so that things don't slip through the cracks 👀 Also, to coordinate messaging and what-not internally would it be helpful to have an issue template when deprecating items that include the checklist above plus any comms plan we would like to use to share the change with teams? |
@joshblack what's the best to do now? Revert and merge again as I had a quick look at this but then just looked at the options available and used the |
This reverts commit c21b939.
https://github.com/github/primer/issues/2099
Updates the Link
inline
property description and set theunderline
property to "deprecated".