Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundle): add "use client" directive to entrypoints #4128

Merged
merged 4 commits into from
Jan 18, 2024
Merged

feat(bundle): add "use client" directive to entrypoints #4128

merged 4 commits into from
Jan 18, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jan 8, 2024 •
edited
Loading

Reference #4069
Closes #4130

Changelog

New

Changed

  • Add support for "use client" directive to bundle entrypoints

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Build the PR locally and verify that our bundles each have "use client" at the top
  • (If you would like to) try out the canary version of this PR in Next.js with the app router and see if you get the original error from the parent issue

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: fdc6901

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.96 KB (0%)
dist/browser.umd.js 105.53 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4128 January 8, 2024 19:12 Inactive
@joshblack joshblack mentioned this pull request Jan 8, 2024
Closed
This was referenced Jan 15, 2024
Closed
Closed
@joshblack joshblack marked this pull request as ready for review January 17, 2024 19:37
@joshblack joshblack requested review from a team, pksjce and broccolinisoup January 17, 2024 19:37
broccolinisoup
broccolinisoup approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks great! Thank you so much for this PR 🙌🏻 I tested on local, built and can definitely see the 'use client' directive 👀

@joshblack joshblack added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 359213b Jan 18, 2024
32 checks passed
@joshblack joshblack deleted the experiment/add-use-client-support branch January 18, 2024 23:41
@primer primer bot mentioned this pull request Jan 18, 2024
Merged
@joshblack joshblack mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@pksjce pksjce Awaiting requested review from pksjce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Approach for React Server Components
3 participants
@joshblack @broccolinisoup @mperrotti