Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Link inline prop description and deprecate underline #4135

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

dipree
Copy link
Contributor

@dipree dipree commented Jan 9, 2024

https://github.com/github/primer/issues/2099

Updates the Link inline property description and set the underline property to "deprecated".

Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: 5deac0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 10, 2024

size-limit report 📦

Path Size
dist/browser.esm.js 104.96 KB (0%)
dist/browser.umd.js 105.53 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4135 January 10, 2024 09:06 Inactive
@dipree dipree requested a review from joshblack January 10, 2024 09:37
@dipree dipree marked this pull request as ready for review January 11, 2024 08:08
@dipree dipree requested a review from a team January 11, 2024 08:08
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just left a comment on where @deprecated could live, hope it makes sense and let me know if you have any questions!

src/Link/Link.tsx Outdated Show resolved Hide resolved
dipree and others added 2 commits January 11, 2024 17:16
Co-authored-by: Josh Black <joshblack@github.com>
@dipree
Copy link
Contributor Author

dipree commented Jan 11, 2024

@joshblack I see how that works now, thanks and updated.

@dipree dipree added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit c2b069c Jan 12, 2024
30 checks passed
@dipree dipree deleted the dipree/update-link-inline-prop-description branch January 12, 2024 18:45
@primer primer bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants