Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): add font stack as fallback to custom property #4208

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

joshblack
Copy link
Member

Update the value for mono in our theme. The font stack is now the fallback value of the CSS Custom Property

Changelog

New

Changed

  • Update mono font family value in theme

Removed

Rollout strategy

  • Patch release

Testing & Reviewing

  • Verify code snippets and other instances that use a mono value from the theme now render with the correct font family

@joshblack joshblack requested review from a team and siddharthkp February 1, 2024 19:07
Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: a95cec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack changed the title Fix/update font family mono fix(theme): add font stack as fallback to custom property Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

size-limit report 📦

Path Size
dist/browser.esm.js 113.24 KB (+0.01% 🔺)
dist/browser.umd.js 113.88 KB (+0.01% 🔺)

@joshblack joshblack added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 2217cef Feb 1, 2024
30 checks passed
@joshblack joshblack deleted the fix/update-font-family-mono branch February 1, 2024 19:32
@primer primer bot mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants