Action Bar - Experimental component #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1f5ca6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pksjce
force-pushed
the
pk/action-bar
branch
from
72985bc
to
f204151
Compare
size-limit report 📦
|
|
How are you assessing for accessibility for this component? |
pksjce
force-pushed
the
pk/action-bar
branch
from
1b661ee
to
33e189f
Compare
|
@JoseInTheArena - My first tests will be to use VoiceOver and makes sure the announcements are coherent. Along with that I also test keyboard accessibility and support for 200% zoom. After this I will ask accessibility team for help with further review by applying to attend office hours. |
pksjce
force-pushed
the
pk/action-bar
branch
from
a0c365c
to
13f854c
Compare
siddharthkp
approved these changes
Feb 22, 2024
pksjce
force-pushed
the
pk/action-bar
branch
from
b6d4e90
to
fcf07a8
Compare
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Add new Actionbar component * Add size context to ActionBar * Add parent styles * Get the overflow somewhat working * Fix calculations * Show More button appropriately * Enhance overflow behaviour and add proper menu items * Remove selection variant * Add comment box story as example * Add logic to show divider * Add docs * Fix builds * Switch to drafts * Remove stories from docs for now * Update snapshots for exports * Create old-peas-cross.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new experimental component called
ActionBarwhich is a horizontal list of icon buttons to be used in the Comment Editor.Here's a demo of the storybook complete with overflow behaviour
Screen.Recording.2024-02-20.at.11.27.43.pm.mov
Closes #https://github.com/github/primer/issues/3020
Changelog
New
In this PR
ActionBaridentical to functionality of its rails counterpart.Rollout strategy
This PR does not need a changeset since it only introduces a draft or experimental component.
Testing & Reviewing
Please test using the storybook deployment
Merge checklist