Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectPanel2: Submit panel when an item is selected with Enter #4265

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 13, 2024

  • Pressing Space selects and deselects the focused item
  • Pressing Enter selects and deselects the focused item AND submits and closes panel
selectpanel-enter.mp4

Known bug: Pressing Enter in the search input also submits the panel which it should not, will update that after #4199 is merged

@siddharthkp siddharthkp added the patch release bug fixes, docs, housekeeping label Feb 13, 2024
@siddharthkp siddharthkp self-assigned this Feb 13, 2024
Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 647bdb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp marked this pull request as ready for review February 13, 2024 16:12
@siddharthkp siddharthkp requested a review from a team February 13, 2024 16:12
Copy link
Contributor

github-actions bot commented Feb 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.37 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 114.01 KB (-0.01% 🔽)

@siddharthkp siddharthkp added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 19c716f Feb 13, 2024
30 checks passed
@siddharthkp siddharthkp deleted the drafts-selectpanel-enter-to-submit branch February 13, 2024 16:37
@primer primer bot mentioned this pull request Feb 13, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
* submit on Enter

* Create polite-rockets-yawn.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release bug fixes, docs, housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants