Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-memoized item lists #4324

Closed
wants to merge 4 commits into from

Commits on Feb 28, 2024

  1. Allow non-memoized item lists

    Towards primer#4315
    
    The SelectPanel only did a basic equality check for the item state, meaning
    that it depended on having the exact same objects on multiple pass throughs.
    
    This isn't always possible as sometimes you may want to have different objects.
    
    This replaces the equality check with a test for an `id` property on the object.
    
    If the `id` property isn't present, we fallback to the old behavior.
    
    Note that a previous version used the `key` prop, but we decided `id` was a
    better interface. f472da2#r139163795
    Co-authored-by: Andrew Henry <ajhenry@github.com>
    ipc103 committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c73102c View commit details
    Browse the repository at this point in the history
  2. Allow non-memoized item lists

    Towards primer#4315
    
    The SelectPanel only did a basic equality check for the item state, meaning
    that it depended on having the exact same objects on multiple pass throughs.
    
    This isn't always possible as sometimes you may want to have different objects.
    
    This replaces the equality check with a test for an `id` property on the object.
    
    If the `id` property isn't present, we fallback to the old behavior.
    
    Note that a previous version used the `key` prop, but we decided `id` was a
    better interface. f472da2#r139163795
    Co-authored-by: Andrew Henry <ajhenry@github.com>
    ipc103 committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    82af2f0 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    f916ed6 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    b4253e9 View commit details
    Browse the repository at this point in the history