Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add word-break to ActionList #4331

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Add word-break to ActionList #4331

merged 10 commits into from
Apr 15, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Feb 29, 2024 •
edited
Loading

Allow long strings without natural breaks to break-word in ActionList item.

Before:
dont break word

After:
break word

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1c02482

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 88.25 KB (-0.08% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4331 February 29, 2024 16:54 Inactive
@siddharthkp
Copy link
Member

siddharthkp commented Mar 1, 2024 •
edited
Loading

Surprising that this doesn't update any visual tests! Do you mind adding one just so that we have it for the future!

Side note: This is probably confusing, but the update-snapshots label only updates visual testing screenshots not jest snapshots. For that you need to run npm run test:update

@github-actions github-actions bot temporarily deployed to storybook-preview-4331 April 11, 2024 22:45 Inactive
@langermank
Copy link
Contributor Author

Thanks @siddharthkp, good call. I added a story

break word

@langermank langermank marked this pull request as ready for review April 11, 2024 22:58
@langermank langermank requested a review from a team as a code owner April 11, 2024 22:58
@github-actions github-actions bot temporarily deployed to storybook-preview-4331 April 11, 2024 23:02 Inactive
@langermank langermank requested a review from a team as a code owner April 12, 2024 22:02
@github-actions github-actions bot temporarily deployed to storybook-preview-4331 April 12, 2024 22:05 Inactive
@langermank langermank added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 77846c4 Apr 15, 2024
28 checks passed
@langermank langermank deleted the action-list-break-word branch April 15, 2024 18:31
@primer primer bot mentioned this pull request Apr 15, 2024
Merged
@francinelucca francinelucca mentioned this pull request Oct 23, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup broccolinisoup is a code owner automatically assigned from primer/engineer-reviewers

@ericwbailey ericwbailey Awaiting requested review from ericwbailey ericwbailey is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langermank @siddharthkp @mperrotti