-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Banner): add banner component #4335
Conversation
🦋 Changeset detectedLatest commit: fe5b3ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Hey @joshblack, this is really great already. Do you think we could add the in sidebar example to the playground as well? E.g. like this: |
… into feat/add-banner-exploration
Thanks @lukasoppermann! I believe I addressed the following:
|
@joshblack we should add a test to make sure svgs work to avoid this issue: #3020 |
@lukasoppermann we should be good to go thankfully! What we have right now will only be behind the |
Closes https://github.com/github/primer/issues/3200
Add support for the Banner component to Primer React.
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing