Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageHeader: Address dom order issues (screen reader experience feedback from sign-off) #4358

Merged
merged 25 commits into from
May 29, 2024
Merged

PageHeader: Address dom order issues (screen reader experience feedback from sign-off) #4358

merged 25 commits into from
May 29, 2024

Commits on Mar 6, 2024

  1. Update layout styles so that all interactive elements come after the … 

    …title
    @broccolinisoup
    broccolinisoup committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    77728e4 View commit details
    Browse the repository at this point in the history

  2. Add PageHeder.Breadcrumbs sub component

    @broccolinisoup
    broccolinisoup committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9ba6d27 View commit details
    Browse the repository at this point in the history

  3. remove shapshot check on jest

    @broccolinisoup
    broccolinisoup committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    cc0481b View commit details
    Browse the repository at this point in the history

  4. test(vrt): update snapshots

    @broccolinisoup @github-actions
    broccolinisoup authored and github-actions[bot] committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    7fcea90 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'main' into pageheader-sign-off-review-address

    @broccolinisoup
    broccolinisoup committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b56d331 View commit details
    Browse the repository at this point in the history

  2. test(vrt): update snapshots

    @broccolinisoup @github-actions
    broccolinisoup authored and github-actions[bot] committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    62ae642 View commit details
    Browse the repository at this point in the history

  3. make the interactive element in the heading check a warning not error

    @broccolinisoup
    broccolinisoup committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3d701d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'main' into pageheader-sign-off-review-address

    @broccolinisoup
    broccolinisoup authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e1bc42d View commit details
    Browse the repository at this point in the history

  2. add pageheader story for screen reader tes

    @broccolinisoup
    broccolinisoup committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    621482d View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. add links

    @broccolinisoup
    broccolinisoup committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3ad5339 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Merge branch 'main' into pageheader-sign-off-review-address

    @broccolinisoup
    broccolinisoup committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5fbee68 View commit details
    Browse the repository at this point in the history

  2. add onclick events to the buttons

    @broccolinisoup
    broccolinisoup committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    61946d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. add a placeholder for file content example

    @broccolinisoup
    broccolinisoup committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    98b2e88 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into pageheader-sign-off-review-address

    @broccolinisoup
    broccolinisoup authored May 7, 2024
    Configuration menu
    Copy the full SHA
    44bd6d8 View commit details
    Browse the repository at this point in the history

  2. test(vrt): update snapshots

    @broccolinisoup @github-actions
    broccolinisoup authored and github-actions[bot] committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9d7b8e8 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into pageheader-sign-off-review-address

    @broccolinisoup
    broccolinisoup committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5b82778 View commit details
    Browse the repository at this point in the history

  2. elements losing context when viewport is narrrow - keep the same text… 

    … for buttons in all viewports
    @broccolinisoup
    broccolinisoup committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b2d9692 View commit details
    Browse the repository at this point in the history

  3. fix linting

    @broccolinisoup
    broccolinisoup committed May 8, 2024
    Configuration menu
    Copy the full SHA
    207b1a7 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. test(vrt): update snapshots

    @broccolinisoup @github-actions
    broccolinisoup authored and github-actions[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    17a75a3 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. hide the overflow menu in narrow since we show it on the context area

    @broccolinisoup
    broccolinisoup committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0bd22ee View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. accomodate different format sx prop for font size

    @broccolinisoup
    broccolinisoup committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e74f862 View commit details
    Browse the repository at this point in the history

  2. when no fontsize is specified css var returns as an empty string so n… 

    …eed ternary instead of Nullish coalescing
    @broccolinisoup
    broccolinisoup committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b34b7db View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pageheader-sign-off-review-address

    @broccolinisoup
    broccolinisoup authored May 17, 2024
    Configuration menu
    Copy the full SHA
    8ed41bf View commit details
    Browse the repository at this point in the history

  4. temporary fix on navlist

    @broccolinisoup
    broccolinisoup committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5c24dab View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' into pageheader-sign-off-review-address

    @broccolinisoup
    broccolinisoup authored May 23, 2024
    Configuration menu
    Copy the full SHA
    7bb732d View commit details
    Browse the repository at this point in the history