Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay: Set style prop correctly #4699

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Overlay: Set style prop correctly #4699

merged 2 commits into from
Jun 27, 2024

Conversation

siddharthkp
Copy link
Member

Sets style prop correctly. It was being overwritten before.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: 8620bfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp added patch release bug fixes, docs, housekeeping react labels Jun 26, 2024
@siddharthkp siddharthkp self-assigned this Jun 26, 2024
@siddharthkp siddharthkp marked this pull request as ready for review June 26, 2024 15:19
@siddharthkp siddharthkp requested a review from a team as a code owner June 26, 2024 15:19
Copy link
Contributor

github-actions bot commented Jun 26, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.03 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 91.32 KB (-0.06% 🔽)

@siddharthkp siddharthkp removed the request for review from mperrotti June 27, 2024 15:56
@siddharthkp siddharthkp added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 546803e Jun 27, 2024
34 checks passed
@siddharthkp siddharthkp deleted the fix-overlay-style-prop branch June 27, 2024 16:11
@primer primer bot mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release bug fixes, docs, housekeeping react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants