-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header: add overflow #4768
Header: add overflow #4768
Conversation
🦋 Changeset detectedLatest commit: 1dcfabb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I see there's some differing opinions on if 1.4.10 Reflow passes with a scrollbar in one dimension or if all content should be fully present in the viewport. I think this is a good approach, and if we need to iterate further in the future we can. I don't think we need to go the strict route since the usage of this component is limited, and part of the responsibility is on the consumer, at least for now.
Note: This is a bit of a silly fix because it's not common at all to have a scrollable Header.
However, this component however is an outdated pattern that is barely used: 6 instances in dotcom out of 0 are as it's intended usage as a navigation header. 5 in other places. We have alternatives like UnderlineNav that are recommended.
So this feels like a safe change to make to pass an accessibility review without getting into a rabbit hole about correct usage or deprecation in this PR