refactor: remove stub folders for TypeScript resolution #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf5b3c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
changed the title
size-limit report 📦
|
…odemods-sub-folders
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/343976 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…odemods-sub-folders
joshblack
had a problem deploying
to
github-pages
GitHub Actions
Failure
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/3665
Changelog
New
Changed
Removed
codemodsfolder has been removed as it is no longer needed. If we would like to use this in the future, we can revisit where we would like this to live 👀Rollout strategy
I believe the removal of the stub folders will trigger any consumer using Primer React and the
nodemoduleResolution option may end up seeing an issue when importing from sub-paths. As a result, they should update their moduleResolution option to node16 or higher