Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant prop to Heading #4806

Merged
merged 23 commits into from
Aug 7, 2024
Merged

Add variant prop to Heading #4806

merged 23 commits into from
Aug 7, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Aug 1, 2024

UI mob pair session 💅

Changelog

New

  • Adds new variant prop for styling small, medium, and large headings

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@langermank langermank requested a review from a team as a code owner August 1, 2024 17:30
Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: e4ad72f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 1, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.05 KB (+0.27% 🔺)
packages/react/dist/browser.umd.js 96.39 KB (+0.21% 🔺)

@primer primer bot requested a review from a team as a code owner August 1, 2024 18:26
@primer primer bot requested a review from maximedegreve August 1, 2024 18:26
@github-actions github-actions bot temporarily deployed to storybook-preview-4806 August 1, 2024 18:31 Inactive
@@ -0,0 +1,5 @@
---
"@primer/react": patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@primer/react": patch
"@primer/react": minor

@joshblack joshblack added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 84d1604 Aug 7, 2024
30 checks passed
@joshblack joshblack deleted the heading-component-style-props branch August 7, 2024 18:05
@primer primer bot mentioned this pull request Aug 7, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants