Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Button component #4807

Merged
merged 15 commits into from
Sep 26, 2024
Merged

Remove deprecated Button component #4807

merged 15 commits into from
Sep 26, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Aug 1, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3695

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 41bfb14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.14 KB (0%)
packages/react/dist/browser.umd.js 98.63 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4807 August 1, 2024 18:27 Inactive
@langermank @joshblack
Update .changeset/strong-tables-rest.md
607db7b 
Co-authored-by: Josh Black <joshblack@github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview-4807 August 1, 2024 18:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4807 August 1, 2024 19:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4807 August 1, 2024 20:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4807 September 25, 2024 22:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4807 September 25, 2024 23:08 Inactive
@langermank langermank marked this pull request as ready for review September 25, 2024 23:40
@langermank langermank requested a review from a team as a code owner September 25, 2024 23:40
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344202

@langermank langermank added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 055c9a7 Sep 26, 2024
32 checks passed
@langermank langermank deleted the remove-deprecated-button branch September 26, 2024 16:35
@primer primer bot mentioned this pull request Sep 26, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @joshblack