export FilteredActionList #4816
Conversation
🦋 Changeset detectedLatest commit: 839501c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
packages/react/src/index.ts
Outdated
| @@ -206,3 +206,6 @@ export type {PageHeaderProps} from './PageHeader' | |||
| export {SSRProvider, useSSRSafeId} from './utils/ssr' | |||
| export {default as sx, merge} from './sx' | |||
| export type {SxProp} from './sx' | |||
|
|
|||
| export {FilteredActionList} from './FilteredActionList' | |||
| export type {FilteredActionListProps} from './FilteredActionList' | |||
There was a problem hiding this comment.
Question for reviewer:
Should we export this from experimental instead? It isn't really experimental because it's been what powers SelectPanel from the start.
But if we want to treat this as a temporary solution, then it feels okay
There was a problem hiding this comment.
I'm down with experimental if it means we won't have to go through a deprecated flow 😂 But if we still have to go through that, then stable is fine 👍
(Separate from this PR) this could be a good example for spots where an unstable_* convention could help out without having to couple things to entry points
There was a problem hiding this comment.
My only comment is that it would be great to treat it as an experimental/unstable component so that we don't have to worry about semver in case if we need to make any changes for the SelectPanel remediation.
There was a problem hiding this comment.
Valid, moved it to experimental
Closes #4840
Changelog
While work on SelectPanel is on-going, there is a gap between the design of SelectPanel and the implementation in PRC.
In order to fill the gap with a temporary solution, developers can opt to build a custom implementation. Exporting FilteredActionList, which lies under SelectPanel, would help.
More context on Slack: https://github.slack.com/archives/CSGAVNZ19/p1722543563922769?thread_ts=1722472095.221459&cid=CSGAVNZ19
Rollout strategy
Merge checklist