Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add className prop to FormControl #4824

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Add className prop to FormControl #4824

merged 2 commits into from
Aug 7, 2024

Conversation

iansan5653
Copy link
Contributor

Closes #4823

Changelog

New

  • Adds className prop to FormControl component

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: f5d6fce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iansan5653 iansan5653 marked this pull request as ready for review August 7, 2024 17:48
@iansan5653 iansan5653 requested a review from a team as a code owner August 7, 2024 17:48
Copy link
Contributor

github-actions bot commented Aug 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.89 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js 96.21 KB (+0.02% 🔺)

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@joshblack joshblack added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit b85d505 Aug 7, 2024
30 checks passed
@joshblack joshblack deleted the formcontrol-classname branch August 7, 2024 20:10
@primer primer bot mentioned this pull request Aug 7, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormControl component is missing className prop
2 participants