Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Label): Refactor Label component to use CSS modules behind feature flag #4893

Merged
merged 11 commits into from
Sep 5, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Aug 28, 2024

Part of https://github.com/github/primer/issues/3914

Changelog

Changed

Label refactored to use CSS modules behind the feature flag primer_react_css_modules_team

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 81e9f2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.54 KB (+0.14% 🔺)
packages/react/dist/browser.umd.js 96.82 KB (+0.17% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4893 September 3, 2024 16:33 Inactive
@jonrohan jonrohan changed the title Convert Label to css modules refactor(Label): Refactor Label component to use CSS modules behind feature flag Sep 4, 2024
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥 snapshot updates look good

@jonrohan jonrohan added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 1b098ed Sep 5, 2024
30 checks passed
@jonrohan jonrohan deleted the css_modules_label branch September 5, 2024 16:38
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants