feat(Banner): update Banner to use CSS Modules behind feature flag #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4bf2a22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jonrohan
reviewed
Sep 5, 2024
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
reviewed
Sep 16, 2024
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…anner-to-css-modules
…imer/react into refactor/update-banner-to-css-modules
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
13 tasks
TylerJDev
pushed a commit
that referenced
this pull request
Sep 23, 2024
…4913) * feat(Banner): update Banner to use CSS Modules behind feature flag * chore: add changeset * chore: remove autogenerated pnpm packageManager change * chore: fix stylelint errors * chore: add back in underline for fallback case * refactor: update autofix and eslint warning * chore: update class order for tests * chore: fix stylelint errors * Update packages/react/src/Banner/Banner.module.css Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com> --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/3882
Changelog
New
Changed
Bannerto use CSS Modules behind a feature flagLinkto no longer forwardunderlineto the underlying nodeRemoved
Rollout strategy