Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates DataTable Pagination component to prevent large numbers from running together #4918

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

mperrotti
Copy link
Contributor

Closes #4636

Screenshots

Before

Screenshot 2024-09-04 at 9 33 09 PM

After

Screenshot 2024-09-04 at 9 32 18 PM

Changelog

New

Changed

  • Adds padding to DataTable Pagination buttons

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner September 5, 2024 01:33
Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: f0fb263

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.41 KB (0%)
packages/react/dist/browser.umd.js 96.65 KB (0%)

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mperrotti mperrotti added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit a17e689 Sep 5, 2024
34 of 36 checks passed
@mperrotti mperrotti deleted the mp/datatable-pagination-padding-fix branch September 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Table Pagination - when the page numbers in the 1000s the page numbers are unreadable
3 participants