Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated MarkdownEditor, MarkdownInput, InlineAutocomplete, and related code #4953

Merged
merged 17 commits into from
Sep 17, 2024
Merged

Delete deprecated MarkdownEditor, MarkdownInput, InlineAutocomplete, and related code #4953

merged 17 commits into from
Sep 17, 2024

Conversation

iansan5653
Copy link
Contributor

@iansan5653 iansan5653 commented Sep 12, 2024 •
edited
Loading

Changelog

Removed

Deprecated experimental components and hooks:

  • MarkdownEditor
  • MarkdownViewer
  • InlineAutocomplete
  • useCombobox
  • useDynamicTextareaHeight
  • useIgnoreKeyboardActionsWhileComposing
  • useSafeAsyncCallback
  • useSyntheticChange
  • useUnifiedFileSelect

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@iansan5653 iansan5653 requested a review from a team as a code owner September 12, 2024 16:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5a9e172

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 16:21 Inactive
@iansan5653 iansan5653 requested a review from a team as a code owner September 12, 2024 16:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.46 KB (0%)
packages/react/dist/browser.umd.js 97.72 KB (0%)

@iansan5653 iansan5653 changed the title Delete markdowneditor Delete deprecated MarkdownEditor, MarkdownInput, InlineAutocomplete, and related code Sep 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 16:25 Inactive
@joshblack joshblack self-requested a review September 12, 2024 16:29
@joshblack joshblack mentioned this pull request Sep 12, 2024
Closed
@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 17:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 17:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 20:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 21:03 Inactive
broccolinisoup
broccolinisoup reviewed Sep 13, 2024
View reviewed changes
packages/react/src/TooltipV2/Tooltip.tsx Outdated
// https://github.com/jsdom/jsdom/issues/3426
// Note: jsdom (jest) does not support `:focus-visible` yet
// https://github.com/jsdom/jsdom/issues/3426
if (!event.target.matches(':focus-visible') && !isJSDOM()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If reading the line of !event.target.matches(':focus-visible') doesn't throw an error (looks like it doesn't since the tests are all green), we are good!

joshblack
joshblack approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just waiting for a PR upstream to help with the type errors coming up since the location has changed 👀

@iansan5653
Copy link
Contributor Author

Just waiting for a PR upstream to help with the type errors coming up since the location has changed 👀

https://github.com/github/github/pull/342097

@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 17, 2024 15:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4953 September 17, 2024 15:14 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/342570

@joshblack
Copy link
Member

Going to merge this in since I believe the failures upstream are related to changes we are already making in: https://github.com/github/github/pull/342428 for RC.5 👍

Thanks again for doing this @iansan5653! It was such a big help

@joshblack joshblack added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 04e8c9c Sep 17, 2024
32 checks passed
@joshblack joshblack deleted the delete-markdowneditor branch September 17, 2024 16:58
@primer primer bot mentioned this pull request Sep 17, 2024
Merged
@broccolinisoup broccolinisoup mentioned this pull request Sep 19, 2024
Closed
13 tasks
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
@iansan5653 @joshblack @TylerJDev
Delete deprecated MarkdownEditor, MarkdownInput, `InlineAutocompl…
33d9e1c 
…ete`, and related code (#4953)

* Delete `MarkdownEditor`, `MarkdownInput`, and `InlineAutocomplete`

* Add changeset

* Delete snapshots

* Update jest config and delete character-coordinates utils

* Delete the `fzy` dependency

* chore: add label to CommentBos story

* test(vrt): update snapshots

* fix: restore useSlots export from drafts

* test: update tooltip test for bump in jsdom

* Re-add slots and overflow exports

* Try resetting the lockfile?

* Switch logic to fix test output

* Revert tooltip changes, no idea how those snuck in

* Fix experimental hooks export

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup left review comments

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MarkdownEditor from @primer/react
3 participants
@iansan5653 @joshblack @broccolinisoup