Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing wide CSS + className to Stack #4957

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Add missing wide CSS + className to Stack #4957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02691e6
add missing css + classname
langermank Sep 12, 2024
36f5057
Create fuzzy-jobs-deny.md
langermank Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-jobs-deny.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Add missing `wide` CSS + className to Stack
8 changes: 8 additions & 0 deletions packages/react/src/Stack/Stack.docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
"name": "padding",
"type": "'none' | 'condensed' | 'normal' | 'spacious' | ResponsiveValue<'none' | 'condensed' | 'normal' | 'spacious'>",
"description": "Specify the padding of the stack container."
},
{
"name": "className",
"type": "string"
}
],
"subcomponents": [
Expand All @@ -45,6 +49,10 @@
"name": "grow",
"type": "boolean | ResponsiveValue<boolean>",
"description": "Allow item to keep size or expand to fill the available space."
},
{
"name": "className",
"type": "string"
}
]
}
Expand Down
15 changes: 14 additions & 1 deletion packages/react/src/Stack/Stack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,14 @@ const StyledStack = styled.div`
&[data-justify-wide='space-evenly'] {
justify-content: space-evenly;
}

&[data-wrap-wide='wrap'] {
flex-wrap: wrap;
}

&[data-wrap-wide='nowrap'] {
flex-wrap: nowrap;
}
}
`

Expand Down Expand Up @@ -342,6 +350,7 @@ type StackProps<As> = React.PropsWithChildren<{
* @default none
*/
padding?: Padding
className?: string
}>

function Stack<As extends ElementType>({
Expand All @@ -353,6 +362,7 @@ function Stack<As extends ElementType>({
justify = 'start',
padding = 'none',
wrap = 'nowrap',
className,
...rest
}: StackProps<As> & React.ComponentPropsWithoutRef<ElementType extends As ? As : 'div'>) {
const BaseComponent = as ?? 'div'
Expand All @@ -361,6 +371,7 @@ function Stack<As extends ElementType>({
<StyledStack
{...rest}
as={BaseComponent}
className={className}
{...getResponsiveAttributes('gap', gap)}
{...getResponsiveAttributes('direction', direction)}
{...getResponsiveAttributes('align', align)}
Expand Down Expand Up @@ -416,18 +427,20 @@ type StackItemProps<As> = React.PropsWithChildren<{
* @default false
*/
grow?: boolean | ResponsiveValue<boolean>
className?: string
}>

function StackItem<As extends ElementType>({
as,
children,
grow,
className,
...rest
}: StackItemProps<As> & React.ComponentPropsWithoutRef<ElementType extends As ? As : 'div'>) {
const BaseComponent = as ?? 'div'

return (
<StyledStackItem {...rest} as={BaseComponent} {...getResponsiveAttributes('grow', grow)}>
<StyledStackItem {...rest} as={BaseComponent} className={className} {...getResponsiveAttributes('grow', grow)}>
{children}
</StyledStackItem>
)
Expand Down
Loading