SelectPanel: High contrast theme #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f28f75e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
changed the title
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
commented
Sep 17, 2024
There was a problem hiding this comment.
Note for reviewer: Our visual tests run on linux so this isn't exactly how it looks in windows. (see PR description for screenshots) but I think adding these to our snapshots will at least help us catch unexpected changes because we rarely test these manually
The light theme one is surprisingly similar, but the dark theme is just very different
TylerJDev
pushed a commit
that referenced
this pull request
Sep 23, 2024
* use border-width to make icon visible * ActionList: include active-descendant for high contrast * e2e test for forced-colors (windows high contrast) * test(vrt): update snapshots * Create ten-gifts-own.md * update snapshots --------- Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-09-16.at.4.05.12.PM.mov
Screen.Recording.2024-09-16.at.4.04.22.PM.mov
Rollout strategy
Testing & Reviewing
Merge checklist