-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: promote Tooltip, Dialog, Stack to stable #5010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9880ade The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
September 23, 2024 18:11
— with
GitHub Actions
Inactive
…/react into feat/promote-tooltip-dialog-stack
@broccolinisoup could this go out in the next release, if possible? 🙏 |
broccolinisoup
temporarily deployed
to
github-pages
October 7, 2024 23:41
— with
GitHub Actions
Inactive
broccolinisoup
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Tooltip
(V2),Dialog
(V2), andStack
to stable entrypoint. This is a part of our v37 release.Changelog
New
Changed
@primer/react
@primer/react
Add Stack toApparently this was already done 😂@primer/react
Removed
Rollout strategy
We will remove these components from
@primer/react/next
and@primer/react/experimental
once dotcom is migrated