Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner: Fix alignment of secondary action without primary action #5026

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Banner: Fix alignment of secondary action without primary action #5026

merged 4 commits into from
Sep 25, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Sep 25, 2024 •
edited
Loading

Before After
After: secondary button and dismiss button are aligned Before: secondary button is misaligned with dismiss button

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@siddharthkp siddharthkp self-assigned this Sep 25, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 97a8a85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 25, 2024
@siddharthkp siddharthkp marked this pull request as ready for review September 25, 2024 14:27
@siddharthkp siddharthkp requested a review from a team as a code owner September 25, 2024 14:27
@github-actions github-actions bot temporarily deployed to storybook-preview-5026 September 25, 2024 14:28 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.26 KB (0%)
packages/react/dist/browser.umd.js 98.57 KB (0%)

@primer primer bot requested a review from a team as a code owner September 25, 2024 14:35
@primer primer bot requested a review from emilybrick September 25, 2024 14:35
@github-actions github-actions bot temporarily deployed to storybook-preview-5026 September 25, 2024 14:38 Inactive
joshblack
joshblack approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 🙏

@siddharthkp siddharthkp changed the title Banner: Fix alignment of secondary button on it's own Banner: Fix alignment of secondary action without primary action Sep 25, 2024
@joshblack
Copy link
Member

I wonder what's going on in the snapshots 🤔 it seems to look correct locally and in the checked in screenshots

@siddharthkp
Copy link
Member Author

I wonder what's going on in the snapshots 🤔 it seems to look correct locally and in the checked in screenshots

Yeah kinda weird, given that the snapshots were just added 😓 Running it once more

@github-actions github-actions bot temporarily deployed to storybook-preview-5026 September 25, 2024 15:16 Inactive
@siddharthkp
Copy link
Member Author

siddharthkp commented Sep 25, 2024 •
edited
Loading

@joshblack figured it out, didn't realise Banner has 2 places with css now!! 😅

@siddharthkp siddharthkp added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 3302440 Sep 25, 2024
38 checks passed
@siddharthkp siddharthkp deleted the banner/fix-secondary-action-alignment branch September 25, 2024 15:47
@primer primer bot mentioned this pull request Sep 25, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@camertron camertron Awaiting requested review from camertron camertron is a code owner automatically assigned from primer/engineer-reviewers

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

Assignees

@siddharthkp siddharthkp

Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @joshblack