fix(TooltipV2): always add aria-hidden

[francinelucca]

Relates to https://github.com/github/primer/issues/3457

Currently the TooltipV2 only adds aria-hidden=true if tooltip is of type label. This is causing voiceover to announce the tooltip twice for "description" type tooltips: once for the tooltiped element's aria-describedby, and once again for the actual tooltip item. This PR Adds aria-hidden=true always to the Tooltip component to prevent screen readers from announcing the tooltip twice on MAC voiceover.

Changelog

New

• aria-hidden=true in description type test

Changed

• aria-hidden=true is always added to TooltipV2 component
• Update ActionMenu tests to account for aria-hidden tooltip

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Test production story against deployment. Notice tooltip is read out twice when using mac voiceover on prod but only once on deployment

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: 6952f99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	96.69 KB (-0.09% 🔽)
packages/react/dist/browser.umd.js	97.06 KB (-0.03% 🔽)

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344522

[broccolinisoup]

Thank you! It looks great - are there any commits at dotcom that need to go with this PR? @francinelucca

[francinelucca]

Thank you! It looks great - are there any commits at dotcom that need to go with this PR? @francinelucca

Yes! dotcom PR is up here

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!