fix(Banner): rewrite PrimaryAction & SecondaryAction types

[francinelucca]

Closes https://github.com/github/primer/issues/3967

Modifies the Banner.PrimaryAction and Banner.SecondaryAction component types to solve for current type error when attempting to use as prop.

Changelog

Changed

Updates Banner.PrimaryAction & Banner.SecondaryAction to export as a PolymorphicForwardRefComponent to allow for better type inference and usage of the as prop.

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

If desired, you may render a Banner in your local environment to test with:

 primaryAction={<Banner.PrimaryAction as={Link} href="" />}
      secondaryAction={
        <Banner.SecondaryAction as={Link} href="">
          Button
        </Banner.SecondaryAction>
      }

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: ced3929

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	96.78 KB (0%)
packages/react/dist/browser.umd.js	97.08 KB (0%)

[francinelucca]

I don't think we necessarily care about forwarding a ref here but it's the only way I found to get the type-checking to pass (mimicked Button). Open to suggestions

[broccolinisoup]

It makes sense to me, I'd do the same but yeah open to be convinced otherwise 😅

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344960

[broccolinisoup]

🔥

[broccolinisoup]

It makes sense to me, I'd do the same but yeah open to be convinced otherwise 😅

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!