Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AnchoredOverlay): replace broken stories #5056

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 2, 2024

Relates to https://github.com/github/primer/issues/3420

Current AnchoredOverlay stories using placekitten are broken due to the site no longer being available. Replaced with a hovercard example (modeled after mona) as suggested here.

mona github user card

Changelog

Changed

  • Replace all usages of placekitten.com with hovercard example

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

docs only update

Testing & Reviewing

N/A

Merge checklist

Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: f2bd114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added staff Author is a staff member skip changeset This change does not need a changelog labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.87 KB (0%)
packages/react/dist/browser.umd.js 97.19 KB (0%)

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Uh oh! @francinelucca, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

…0-prcanchoredoverlay-example-overlay-has-fixed-width
Monalisa Octocat
</Text>
</Stack>
<Text fontSize={14}>Former beach cat and champion swimmer. Now your friendly octapus with a normal face.</Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend using the size prop instead.

Suggested change
<Text fontSize={14}>Former beach cat and champion swimmer. Now your friendly octapus with a normal face.</Text>
<Text size="medium">Former beach cat and champion swimmer. Now your friendly octapus with a normal face.</Text>

Same goes for other places where you're using Text to set the size.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah perfect, will do! thankss 🙏🏼

francinelucca and others added 2 commits October 8, 2024 16:49
…ories.tsx

Co-authored-by: Mike Perrotti <mperrotti@github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview-5056 October 8, 2024 21:04 Inactive
@francinelucca francinelucca added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@francinelucca francinelucca added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 6cd3960 Oct 9, 2024
43 checks passed
@francinelucca francinelucca deleted the francinelucca/3420-prcanchoredoverlay-example-overlay-has-fixed-width branch October 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants