Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Label): Remove CSS modules feature flag from Label component #5060

Merged
merged 12 commits into from
Oct 24, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 3, 2024

This removes the CSS modules feature flag from the Label component that was first introduced 4 weeks ago #4893

Changelog

Changed

Label is styled by CSS modules.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 2bef3a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 3, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5060 October 4, 2024 00:01 Inactive
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.96 KB (-0.17% 🔽)
packages/react/dist/browser.umd.js 97.21 KB (-0.31% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5060 October 7, 2024 23:06 Inactive
@jonrohan jonrohan marked this pull request as ready for review October 8, 2024 17:45
@jonrohan jonrohan requested a review from a team as a code owner October 8, 2024 17:45
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 15, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5060 October 15, 2024 23:07 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/348598

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@jonrohan jonrohan added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 33396ea Oct 24, 2024
43 checks passed
@jonrohan jonrohan deleted the remove_feature_flag_label branch October 24, 2024 15:42
@primer primer bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants