-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel: Fix items not being selected when defined within scope #5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: faf8056 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
added
the
integration-tests: recommended
This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
label
Oct 7, 2024
siddharthkp
changed the title
Selectpanel track by
SelectPanel: Track selection by item.id
Oct 7, 2024
size-limit report 📦
|
siddharthkp
temporarily deployed
to
github-pages
October 7, 2024 11:04
— with
GitHub Actions
Inactive
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/345814 |
🟢 golden-jobs completed with status |
siddharthkp
added
integration-tests: passing
Changes in this PR do NOT cause breaking changes in gh/gh
and removed
integration-tests: recommended
This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
labels
Oct 7, 2024
siddharthkp
changed the title
SelectPanel: Track selection by item.id
SelectPanel: Fix items not being selected when defined within scope
Oct 7, 2024
broccolinisoup
approved these changes
Oct 8, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
integration-tests: passing
Changes in this PR do NOT cause breaking changes in gh/gh
staff
Author is a staff member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectPanel
should compare Objects based onkey
orid
instead of the Objects themselves #4315Rollout strategy
Testing & Reviewing
Merge checklist