Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectPanel: Fix items not being selected when defined within scope #5073

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Oct 7, 2024

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: faf8056

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp self-assigned this Oct 7, 2024
@siddharthkp siddharthkp added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 7, 2024
@github-actions github-actions bot added the staff Author is a staff member label Oct 7, 2024
@siddharthkp siddharthkp changed the title Selectpanel track by SelectPanel: Track selection by item.id Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.72 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 97.01 KB (-0.01% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/345814

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@siddharthkp siddharthkp marked this pull request as ready for review October 7, 2024 12:56
@siddharthkp siddharthkp requested a review from a team as a code owner October 7, 2024 12:56
@siddharthkp siddharthkp added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2024
@siddharthkp siddharthkp changed the title SelectPanel: Track selection by item.id SelectPanel: Fix items not being selected when defined within scope Oct 7, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 472967a Oct 8, 2024
42 checks passed
@siddharthkp siddharthkp deleted the selectpanel-track-by-id branch October 8, 2024 14:21
@primer primer bot mentioned this pull request Oct 8, 2024
@siddharthkp siddharthkp mentioned this pull request Oct 8, 2024
13 tasks
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectPanel should compare Objects based on key or id instead of the Objects themselves
3 participants