Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugFix:(IconButton) Set the min-width of IconButton to unset #5078

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 7, 2024

This bug was found as part of #5070 and manifested in production as some bugs in the Sub-issues drag-n-drop buttons.

You can see the problem this change is trying to fix in the updated Storybook examples for the ActionBar with the flag off vs staff flag on.

Changelog

Changed

Set the min-width of IconButton to unset to resolve layout issues.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner October 7, 2024 17:38
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: a4d2d1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.93 KB (0%)
packages/react/dist/browser.umd.js 97.12 KB (0%)

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we made this change in PVC because of an accessibility failure, but we can re-think this if it comes up again

@jonrohan jonrohan added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 3b7bf41 Oct 7, 2024
33 checks passed
@jonrohan jonrohan deleted the bugfix_icon_button_min_width_unset branch October 7, 2024 19:00
@primer primer bot mentioned this pull request Oct 7, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants