Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProgressBar): add aria-valuetext attribute #5100

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 9, 2024

Closes https://github.com/github/primer/issues/3458

Adds aria-valuetext attribute to ProgressBar component to improve accessibility for screen readers by ensuring percentage value (60% vs just 60) gets read.

Changelog

New

  • Adds aria-valuetext attribute to ProgressBar component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Verify percentage gets read on screen reader

Merge checklist

@francinelucca francinelucca added component: ProgressBar staff Author is a staff member labels Oct 9, 2024
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: f2cfda7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.6 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 97.83 KB (-0.11% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/346662

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@francinelucca francinelucca marked this pull request as ready for review October 10, 2024 23:01
@francinelucca francinelucca requested a review from a team as a code owner October 10, 2024 23:01
@francinelucca francinelucca added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit b0d858a Oct 16, 2024
43 checks passed
@francinelucca francinelucca deleted the 3458-prcprogressbar-best-practice-add-a-human-understandable-value-announcement branch October 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ProgressBar integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants