Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dialog) add className prop #5115

Merged
merged 4 commits into from
Oct 15, 2024
Merged

feat(Dialog) add className prop #5115

merged 4 commits into from
Oct 15, 2024

Conversation

randall-krauskopf
Copy link
Collaborator

Related To: https://github.com/github/collaboration-workflows-flex/issues/1141

Changelog

New

Added className prop to the Dialog component for CSS Module support.

Changed

Removed

Rollout strategy

  • Minor release

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: beb092d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5115 October 11, 2024 17:38 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.54 KB (-0.12% 🔽)
packages/react/dist/browser.umd.js 97.85 KB (-0.08% 🔽)

@randall-krauskopf randall-krauskopf marked this pull request as ready for review October 11, 2024 17:47
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner October 11, 2024 17:47
joshblack
joshblack requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! When you get a chance, could you also add this to Dialog.docs.json? Thanks 🙏

@github-actions github-actions bot temporarily deployed to storybook-preview-5115 October 15, 2024 15:35 Inactive
@randall-krauskopf
Copy link
Collaborator Author

Thanks @joshblack, added the the prop to the correct file 😄

@joshblack joshblack added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit e94f0a1 Oct 15, 2024
43 checks passed
@joshblack joshblack deleted the dialog-class-name branch October 15, 2024 16:02
This was referenced Oct 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp siddharthkp is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randall-krauskopf @joshblack