Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aria-disabled in Button #5126

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

langermank
Copy link
Contributor

Adds style support for aria-disabled on all button variants. Also adds the option to the Playground story.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 4cc4b47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 15, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5126 October 15, 2024 17:36 Inactive
Copy link
Contributor

github-actions bot commented Oct 15, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.59 KB (0%)
packages/react/dist/browser.umd.js 97.84 KB (0%)

@langermank langermank added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit f574372 Oct 16, 2024
43 checks passed
@langermank langermank deleted the aria-disabled-support branch October 16, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants