Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ButtonGroup): Move ButtonGroup css module feature flag to staff #5144

Merged
merged 4 commits into from
Nov 5, 2024
Merged

chore(ButtonGroup): Move ButtonGroup css module feature flag to staff #5144

merged 4 commits into from
Nov 5, 2024

Conversation

jonrohan
Copy link
Member

Changelog

Changed

Move ButtonGroup css module feature flag to staff

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 926bb57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 17, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5144 October 17, 2024 23:30 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.44 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js 98.93 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5144 October 21, 2024 20:11 Inactive
@jonrohan jonrohan marked this pull request as ready for review November 4, 2024 23:24
@jonrohan jonrohan requested a review from a team as a code owner November 4, 2024 23:24
@jonrohan jonrohan added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 271d063 Nov 5, 2024
43 checks passed
@jonrohan jonrohan deleted the move_button_group_to_staff branch November 5, 2024 18:40
@primer primer bot mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@camertron camertron Awaiting requested review from camertron camertron is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack