chore(Link): Remove the CSS modules feature flag from the Link component #5148
Conversation
🦋 Changeset detectedLatest commit: 8dfeec6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
size-limit report 📦
|
| data-inline={inline} | ||
| underline={underline} | ||
| data-underline={underline} | ||
| {...props} | ||
| // @ts-ignore shh | ||
| ref={innerRef} |
There was a problem hiding this comment.
I probably don't need this ref anymore? @joshblack
There was a problem hiding this comment.
I think it's used in the effect for checking the ref type IIRC, let me know if I'm missing something 👀
| import Box from '../Box' | ||
| import type {ComponentProps} from '../utils/types' | ||
| import type {ForwardRefComponent as PolymorphicForwardRefComponent} from '../utils/polymorphic' | ||
|
|
||
| type StyledLinkProps = { | ||
| /** @deprecated use CSS modules to style hover color */ | ||
| hoverColor?: string |
There was a problem hiding this comment.
If you haven't already, could you add a note to https://github.com/github/primer/issues/3541 for removing this from Link? 🙏
| data-inline={inline} | ||
| underline={underline} | ||
| data-underline={underline} | ||
| {...props} | ||
| // @ts-ignore shh | ||
| ref={innerRef} |
There was a problem hiding this comment.
I think it's used in the effect for checking the ref type IIRC, let me know if I'm missing something 👀
|
|
||
| &:hover { | ||
| text-decoration: ${props => (props.muted ? 'none' : 'underline')}; | ||
| ${props => (props.hoverColor ? hoverColor : props.muted ? `color: ${get('colors.accent.fg')(props)}` : '')}; |
There was a problem hiding this comment.
Are we passing along the hoverColor prop now that it's been decorated? I wasn't sure if we were still supporting it or not and wanted to double check
There was a problem hiding this comment.
It's not doing anything anymore
Changelog
Changed
Remove the CSS modules feature flag from the Link component
Rollout strategy
Testing & Reviewing
Integration tests in dotcom
Merge checklist