-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch tooltip v2 errors in older browsers #5171
Conversation
🦋 Changeset detectedLatest commit: 39843b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! It looks good to me. As you mentioned, we can look into it deeper to see why this is happening in the first place despite the polyfill 🤔
Add try..catch to the functions to open and close the tooltip v2 to avoid flooding sentry with errors. This is a short term solution until the Primer team can get to the bottom of why this is happening even though we have a polyfill in place.
Rollout strategy
Testing & Reviewing
Try to use a tooltip v2 with an older browser that doesn't support the tooltip api and check for any js errors. We haven't been able to reliably introduce the error, but we're seeing it happen in production.
Merge checklist