Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch tooltip v2 errors in older browsers #5171

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

alondahari
Copy link
Contributor

@alondahari alondahari commented Oct 24, 2024

Add try..catch to the functions to open and close the tooltip v2 to avoid flooding sentry with errors. This is a short term solution until the Primer team can get to the bottom of why this is happening even though we have a polyfill in place.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Try to use a tooltip v2 with an older browser that doesn't support the tooltip api and check for any js errors. We haven't been able to reliably introduce the error, but we're seeing it happen in production.

Merge checklist

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 39843b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 24, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5171 October 24, 2024 11:00 Inactive
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.19 KB (+0.07% 🔺)
packages/react/dist/browser.umd.js 97.5 KB (-0.01% 🔽)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! It looks good to me. As you mentioned, we can look into it deeper to see why this is happening in the first place despite the polyfill 🤔

@alondahari alondahari added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 8138dee Oct 31, 2024
43 checks passed
@alondahari alondahari deleted the catch-tooltip-error-in-older-browsers branch October 31, 2024 11:34
@primer primer bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants