Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): export datatable utility types #5182

Conversation

francinelucca
Copy link
Member

Closes https://github.com/github/primer/issues/4259

Adds experimental exports for DataTable utility types.

Changelog

New

  • Exports DataTable's UniqueRow, CellAlignment, ColumnWidth, ObjectPaths

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 1ee5e63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 28, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5182 October 28, 2024 18:13 Inactive
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.19 KB (0%)
packages/react/dist/browser.umd.js 97.58 KB (0%)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349094

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@francinelucca francinelucca added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 31d9a05 Oct 29, 2024
43 checks passed
@francinelucca francinelucca deleted the francinelucca/4259-add-experimental-exports-for-datatable-helpers-or-utility-types branch October 29, 2024 16:00
@primer primer bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DataTable integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants