Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Select): Convert Select component to CSS Modules behind feature flag #5194

Merged
merged 5 commits into from
Oct 31, 2024
Merged

feat(Select): Convert Select component to CSS Modules behind feature flag #5194

merged 5 commits into from
Oct 31, 2024

Conversation

randall-krauskopf
Copy link
Collaborator

@randall-krauskopf randall-krauskopf commented Oct 30, 2024 •
edited by jonrohan
Loading

Closes https://github.com/github/primer/issues/4299

Changelog

Changed

  • Update the base primer exports and other internal references to use the Select component used in src/Select/Select.tsx instead of the duplicate one located at src/Select.tsx which was causing some confusion.
  • Convert select component to css module behind feature flag.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e9b9710

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 30, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5194 October 30, 2024 20:31 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.54 KB (+0.16% 🔺)
packages/react/dist/browser.umd.js 97.87 KB (+0.12% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5194 October 30, 2024 20:38 Inactive
@randall-krauskopf randall-krauskopf changed the title Feature(Select): Migrate Select component to CSS Modules behind feature flag feat(Select): Convert Select component to CSS Modules behind feature flag Oct 30, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349335

randall-krauskopf
randall-krauskopf commented Oct 30, 2024
View reviewed changes
packages/react/src/FormControl/FormControl.tsx
@@ -3,7 +3,7 @@ import Autocomplete from '../Autocomplete'
import Box from '../Box'
import Checkbox from '../Checkbox'
import Radio from '../Radio'
import Select from '../Select'
import Select from '../Select/Select'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the newest Select component

randall-krauskopf
randall-krauskopf commented Oct 30, 2024
View reviewed changes
packages/react/src/Select/Select.features.stories.tsx Outdated
@@ -1,5 +1,6 @@
import React from 'react'
import {Select, FormControl, Box, Heading} from '..'
import {FormControl, Box, Heading} from '..'
import Select from '.'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get Select from the correct location

randall-krauskopf
randall-krauskopf commented Oct 30, 2024
View reviewed changes
packages/react/src/Select/Select.figma.tsx
@@ -1,5 +1,5 @@
import React from 'react'
import {Select} from '../../src'
import Select from '.'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get Select from the correct location

randall-krauskopf
randall-krauskopf commented Oct 30, 2024
View reviewed changes
packages/react/src/index.ts
export {default as Select} from './Select'
export type {SelectProps} from './Select'
// Curently there is a duplicate Select component at the root of the dir, so need to be explicit about exporting from the src/Select dir
export {default as Select} from './Select/Select'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack Should I explore deleting the src/Select.tsx file in a follow up PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be very much so appreciated if you have the time! 🙏

@github-actions github-actions bot temporarily deployed to storybook-preview-5194 October 30, 2024 20:59 Inactive
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot temporarily deployed to storybook-preview-5194 October 30, 2024 22:50 Inactive
@randall-krauskopf randall-krauskopf marked this pull request as ready for review October 31, 2024 15:50
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner October 31, 2024 15:50
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 719def7 Oct 31, 2024
43 checks passed
@randall-krauskopf randall-krauskopf deleted the select-css-modules branch October 31, 2024 18:05
@primer primer bot mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randall-krauskopf @jonrohan @joshblack