Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SkeletonBox): Convert SkeletonBox to CSS modules behind the feature flag #5195

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 30, 2024

Closes https://github.com/github/primer/issues/4129
Closes https://github.com/github/primer/issues/4360
Closes https://github.com/github/primer/issues/4361

Changelog

New

Changed

  • feat(SkeletonAvatar): Convert SkeletonAvatar to CSS modules behind the feature flag
  • feat(SkeletonBox): Convert SkeletonBox to CSS modules behind the feature flag
  • feat(SkeletonText): Convert SkeletonText to CSS modules behind the feature flag

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 6ad126a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 30, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.2 KB (+0.13% 🔺)
packages/react/dist/browser.umd.js 98.52 KB (+0.19% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5195 October 31, 2024 17:41 Inactive
@jonrohan jonrohan marked this pull request as ready for review October 31, 2024 17:56
@jonrohan jonrohan requested a review from a team as a code owner October 31, 2024 17:56
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349502

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@jonrohan jonrohan added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit d349cfc Nov 1, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_skeleton_box branch November 1, 2024 15:26
@primer primer bot mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants