fix(Treevieew):do not add aria-describedby attribute when empty leading/trailing visual #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng/trailing visual
francinelucca
added
status: review needed
accessibility
component: TreeView
🦋 Changeset detectedLatest commit: 03a0e08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
size-limit report 📦
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349374 |
|
🟢 golden-jobs completed with status |
francinelucca
added
integration-tests: passing
francinelucca
deleted the
francinelucca/4457-treeview-remove-aria-describedby-when-leading-and-trailing-visuals-do-not-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4457
Currently a leadingVisualId and TrailingVisualId are generated and attached to the TreeItem's
aria-describedbyattribute regardless of whether these nodes are supplied to the component or not. This PR refactors the aria-describedby logic in to only addaria-describedbywhen the nodes (for trailing and leading visuals) are actually present, and mark it as undefined otherwise.Changelog
New
Changed
aria-describedbyis only added to TreeItem's when at least one of leading/trailing visual is present and only the present ID(s) is added.Rollout strategy
Testing & Reviewing
Load deployed treeview stories and ensure TreeItem's aria-describedby only contains the Id(s) of the present leading/trailing visual in the various stories.
Merge checklist