-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade prettier to 3.1.0 to help changesets format changelog.md #5238
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Could we also exclude CHANGELOG.md from prettier in |
That wouldn't stop changesets from running prettier on it, but it will stop our format CI job complaining about it. changesets would not format it with our prettier config, which is only slightly annoying. I don't mind. |
@joshblack Update:
|
Hello!
I went into a silly rabbit hole of CI and come back with this:
npm run format
found unrelated changes inCHANGELOG.md
prettierConfig
frompackage.json
Rollout strategy
Testing & Reviewing
Merge checklist