Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade prettier to 3.1.0 to help changesets format changelog.md #5238

Closed
wants to merge 2 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 6, 2024

Hello!

I went into a silly rabbit hole of CI and come back with this:

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

This comment was marked as resolved.

@siddharthkp siddharthkp self-assigned this Nov 6, 2024
@github-actions github-actions bot added the staff Author is a staff member label Nov 6, 2024
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Nov 6, 2024
@siddharthkp siddharthkp marked this pull request as ready for review November 6, 2024 13:26
@siddharthkp siddharthkp requested a review from a team as a code owner November 6, 2024 13:26
@github-actions github-actions bot temporarily deployed to storybook-preview-5238 November 6, 2024 13:27 Inactive
Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.5 KB (0%)
packages/react/dist/browser.umd.js 98.91 KB (0%)

Copy link
Contributor

github-actions bot commented Nov 6, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 6, 2024
@siddharthkp siddharthkp added integration-tests: skipped manually Changes in this PR do not require an integration test and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 6, 2024
@joshblack
Copy link
Member

Could we also exclude CHANGELOG.md from prettier in .prettierignore to avoid downgrading or would that also cause issues? 👀

@siddharthkp
Copy link
Member Author

siddharthkp commented Nov 6, 2024

Could we also exclude CHANGELOG.md from prettier in .prettierignore to avoid downgrading or would that also cause issues? 👀

That wouldn't stop changesets from running prettier on it, but it will stop our format CI job complaining about it.

changesets would not format it with our prettier config, which is only slightly annoying. I don't mind.

@siddharthkp
Copy link
Member Author

siddharthkp commented Nov 6, 2024

@joshblack Update:

@siddharthkp siddharthkp closed this Nov 6, 2024
@siddharthkp siddharthkp deleted the downgrade-prettier-3.1.0 branch November 11, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants