fix(TextInput): Fix font size for small text inputs #5243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f43c477 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
hussam-i-am
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
langermank
approved these changes
Nov 6, 2024
| @@ -4173,6 +4185,14 @@ exports[`TextInput renders with a loading indicator 1`] = ` | |||
| } | |||
| @media screen and (min-width:544px) { | |||
There was a problem hiding this comment.
I wonder why these were added? 🤔
There was a problem hiding this comment.
Yeah, seemed strange but noticed they already existed and so I figured it was some artifact of using styled components.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
New
Changed
smallvariants, so updated thefontSizeto be a responsive array to ensure it is correctly setRemoved
Rollout strategy
Testing & Reviewing
Merge checklist