Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TextInput): Convert TextInput (Part 1) - Deprecate width props #5253

Merged
merged 13 commits into from
Nov 13, 2024
Merged

feat(TextInput): Convert TextInput (Part 1) - Deprecate width props #5253

merged 13 commits into from
Nov 13, 2024

Conversation

hussam-i-am
Copy link
Collaborator

@hussam-i-am hussam-i-am commented Nov 8, 2024 •
edited
Loading

Changelog

New

Changed

  • Deprecates width, maxWidth and minWidth props in advance of switching to CSS modules and only width is used as indicated by Primer Query

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 8, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a9493b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5253 November 8, 2024 20:13 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.79 KB (0%)
packages/react/dist/browser.umd.js 98.99 KB (0%)

@hussam-i-am hussam-i-am marked this pull request as ready for review November 8, 2024 20:17
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 8, 2024 20:17
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5253 November 8, 2024 22:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5253 November 8, 2024 22:51 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5253 November 12, 2024 15:59 Inactive
@hussam-i-am hussam-i-am changed the title feat(TextInput): Remove width props from TextInput feat(TextInput): Convert TextInput (Part 1) - Replace width props Nov 13, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5253 November 13, 2024 16:48 Inactive
joshblack
joshblack reviewed Nov 13, 2024
View reviewed changes
packages/react/src/TextInput/TextInput.tsx Outdated
Comment on lines 50 to 51
| 'maxWidth'
| 'minWidth'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing props like this is typically associated with a deprecate -> remove in next major release flow instead of being included in a single minor release. Is this something that we could batch up for the next major release and deprecate in the current minor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and added to the major release issue: https://github.com/github/primer/issues/3541#issuecomment-2474329371

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@hussam-i-am hussam-i-am changed the title feat(TextInput): Convert TextInput (Part 1) - Replace width props feat(TextInput): Convert TextInput (Part 1) - Deprecate width props Nov 13, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5253 November 13, 2024 17:44 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350854

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Nov 13, 2024
@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 729c0fa Nov 13, 2024
43 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/remove-textinput-width-props branch November 13, 2024 20:38
@primer primer bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

@joshblack joshblack Awaiting requested review from joshblack

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees

@hussam-i-am hussam-i-am

Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hussam-i-am @jonrohan @joshblack