Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProgressBar): Convert ProgressBar to CSS modules behind team feature flag #5304

Merged
merged 12 commits into from
Nov 19, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Nov 15, 2024

Closes https://github.com/github/primer/issues/4304

Changelog

New

  • Converts ProgressBar to CSS modules behind team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: a7161a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100.62 KB (+0.23% 🔺)
packages/react/dist/browser.umd.js 100.93 KB (+0.12% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351565

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5304 November 18, 2024 18:08 Inactive
@TylerJDev TylerJDev marked this pull request as ready for review November 18, 2024 18:24
@TylerJDev TylerJDev requested a review from a team as a code owner November 18, 2024 18:24
border-radius: var(--borderRadius-small);
gap: 2px;

&[data-progress-display='inline'] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something we're doing for the data- attribute selectors is wrapping in :where() which brings the specificity down on the selector so it's easier to override in dotcom.

Suggested change
&[data-progress-display='inline'] {
&:where([data-progress-display='inline']) {

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻

@TylerJDev TylerJDev added this pull request to the merge queue Nov 18, 2024
@TylerJDev TylerJDev removed this pull request from the merge queue due to a manual request Nov 18, 2024
@primer primer bot requested a review from a team as a code owner November 19, 2024 14:29
@primer primer bot requested a review from emilybrick November 19, 2024 14:29
@TylerJDev TylerJDev added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit a3fc488 Nov 19, 2024
43 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/progressbar-css-modules branch November 19, 2024 14:57
@primer primer bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants