Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor engine tests and examples #895

Merged
merged 5 commits into from
Feb 16, 2024
Merged

refactor engine tests and examples #895

merged 5 commits into from
Feb 16, 2024

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed

  • Moved out the integration-type tests into engine/tests/.
  • Moved the timed message mock simulations into engine/tests/mock_simulation.rs
  • Moved the token minter example into the examples/minter/ directory. This can now be run with cargo run --example minter simulate examples/minter/config.toml
  • Added examples into CI so they are also checked.

kinrezC
kinrezC previously approved these changes Feb 16, 2024
View reviewed changes
@Autoparallel
comment ci examples
2f3873a 
Revert "comment ci examples"

This reverts commit 1dee6b1.

Revert "Revert "comment ci examples""

This reverts commit 8bbf24e.
0xJepsen
0xJepsen approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm king

@0xJepsen 0xJepsen merged commit 267c776 into main Feb 16, 2024
7 of 8 checks passed
@0xJepsen 0xJepsen deleted the refactor/engine branch February 16, 2024 00:45
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

@kinrezC kinrezC kinrezC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Autoparallel @kinrezC @0xJepsen