Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support GraphQL 16 #304

Closed
wants to merge 1 commit into from
Closed

feat: support GraphQL 16 #304

wants to merge 1 commit into from

Conversation

NetOpWibby
Copy link

Closes #299

jasonkuhrt
jasonkuhrt requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the CI so that we test with a matrix of GraphQL versions to ensure real compat as claimed by this peer dep spec.

package.json
@@ -48,7 +48,7 @@
"form-data": "^3.0.0"
},
"peerDependencies": {
"graphql": "14.x || 15.x"
"graphql": "14.x || 16.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop 15?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMH, I wasn't even thinking. Clearly this should be a range.

@jasonkuhrt jasonkuhrt changed the title Support GraphQL 16 feat: support GraphQL 16 Nov 19, 2021
@vdhpieter vdhpieter mentioned this pull request Nov 19, 2021
Merged
@jasonkuhrt
Copy link
Member

Superseded by #305

@jasonkuhrt jasonkuhrt closed this Dec 1, 2021
@NetOpWibby
Copy link
Author

Awesome, I forgot about this.

@NetOpWibby NetOpWibby deleted the patch-1 branch December 1, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonkuhrt jasonkuhrt jasonkuhrt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GraphQL v16 support
2 participants
@NetOpWibby @jasonkuhrt