You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If our PlanetScale drivers were set up to be using relationMode = "foreignKeys" in the query-engine test suite, the OCC test cases above would pass with both the Vitess("planetscale.js") (Napi) and the Vitess("planetscale.js.wasm") (Wasm) test tags:
test new::occ::occ::occ_update_many_test ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 4.68s
test new::occ::occ::occ_delete_test ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 1.93s
test new::occ::occ::occ_update_test ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 1.84s
I'd recommend a refactoring of the connector-test-kit-rs test suite setup to allow opting in and out of relationMode = "prisma" | "foreignKeys", so that we can consistently run CI on e.g. OCC tests with PlanetScale. The specifics of this technical change can be discussed with other engineers in the team.
We should fix OCC for relationMode = “prisma” rather than opt out of the test. I beleive a fix is not that hard - we just need to duplicate the filter we used in SELECT in UPDATE as well.
This is a subcluster of failures after having enabled planetscale tests in #4423
Failing tests in this cluster:
Please follow this process
The text was updated successfully, but these errors were encountered: